Uniform usage of ratio as boost::ratio #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a strange ABI issue in a downstream Boost Chrono package (RoboStack/ros-noetic#448), I found an inconsistencies between
std::ratio
andboost::ratio
. I was not able to reproduce the issue, however I noticed that in Boost Chrono there are some inconsistency in the use ofratio
, that sometimes is used asboost::ratio
, and sometimes is used justratio
(this is probably a leftover from the time wherestd::ratio
did not exist).Regardless of the root issue I was experiencing, I think (but I may be wrong) that it may be beneficial to uniform the usage in the library to always use
boost::ratio
, for consistency and avoid confusion withstd::ratio
.