Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sha1 digest type #887

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

mmitti
Copy link
Contributor

@mmitti mmitti commented Aug 19, 2024

In boost 1.86, changing boost::uuids::detail::sha1::digest_type int[5] to char[20]. I was compile current code with MSVC2022, i got compile errors due to those change. So, I fix to folloup those changes to pass compile.

ref: boostorg/uuid@0f84313#diff-8a0985025af60846be9c809585d2659b4e3d5de04714ff76d174b80aaa719c97

@pdimov
Copy link
Member

pdimov commented Aug 22, 2024

This fix is slightly incorrect, because digest[i] is unsigned char and is output as a character to buf, instead as an integer, as intended.

#893 fixes it.
#892 adds a test for the sha1 class. The test passes for 1.85, and after #893.

Additionally, #891 is a small change to the test Jamfile that makes the tests link under Windows as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants