operations: Don't set _FILE_OFFSET_BITS for older Android versions #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build was broken when building for Android < 7.0 with the latest Android NDK (r15c). With earlier NDKs, the build succeeded, but silently used 32b offsets.
|
I'd just forked the project to make a very similar change. Would be really nice to see this merged. Here is a thread discussing this from the Android NDK side: android/ndk#516 Although they believe that 1.64 is good, 1.65.1 certainly doesn't work |
KayEss
added a commit
to hotkit/fost-mobile
that referenced
this pull request
Nov 30, 2017
Once this has been merged to develop we'll switch to there, and when it's in master we'll move to normal Boost releases. boostorg/filesystem#52
|
See also #67. |
|
Now when #69 has been merged, this pull request is not needed any more and can be closed, I think. |
|
Leave a comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was broken when building for Android < 7.0 with the latest
Android NDK (r15c). With earlier NDKs, the build succeeded, but silently
used 32b offsets.