C++11, Fix CI, fix use of deprecated timer, fix group assignment operator. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeking3
force-pushed
the
fix/build
branch
2 times, most recently
from
7e5626b to
7066a62
Compare
jeking3
changed the title
pdimov
reviewed
May 15, 2024
pdimov
reviewed
May 15, 2024
pdimov
reviewed
May 15, 2024
pdimov
reviewed
May 15, 2024
jeking3
force-pushed
the
fix/build
branch
3 times, most recently
from
5406f62 to
47a0dc2
Compare
Example: I thought it would be easier to delete the assignment operator once rather than in each class, but I suppose the complexity goes way up when deriving. |
jeking3
force-pushed
the
fix/build
branch
6 times, most recently
from
8d90f06 to
5f82f96
Compare
Dependencies like optional and smart_ptr will no longer support C++03 therefore the new minimum language level is C++11, and all the CI jobs for both C++98 and C++03 have been removed. Fixed use of the deprecated top level timer class as it was causing build problems using warnings-as-errors. Fixed -Wdeprecated-cast in group.hpp. Fixed -Winvalid-source-encoding in sample_new_features.cpp. Fixed -Wself-assign-overloaded in format_test2.cpp. These changes also allow b2 to work properly when executed from within the format directory.
pdimov
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies like optional and smart_ptr will no longer support C++03 therefore the new minimum language level is C++11, and all the CI jobs for both C++98 and C++03 have been removed. Removed MSVC 2010 and 2012 from CI, moved some windows jobs to GHA.
Fixed use of the deprecated top level timer class as it was causing build problems using <warnings-as-errors>.
Fixed -Wdeprecated-cast in group.hpp.
Fixed -Winvalid-source-encoding in sample_new_features.cpp.
Fixed -Wself-assign-overloaded in format_test2.cpp.
These changes also allow b2 to work properly when executed from within the format directory.
This closes #91.