-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/basic string #427
base: develop
Are you sure you want to change the base?
Feature/basic string #427
Conversation
Hi. It looks like you need to rebase onto the develop branch. Also commits should be squashed into a single commit (Item 5 in https://github.com/boostorg/hana/blob/master/CONTRIBUTING.md) |
Hi. Thank you for the comment. |
71f83c3
to
70038ed
Compare
I renewed the branch from the 'develop branch' a single commit. Regards, |
Try this:
I did not try step 3 myself, but it should update this PR to have only your commit. EDIT: FWIW I don't know how much of an issue the weird commits are, and I am not the one who will accept the PR anyways. |
70038ed
to
4c0fccf
Compare
I learned git operations I have never used these few days 😃
It seems a `clean' commit you might expected. |
- Added classes basic_string and wstring. - Added macros BOOST_HANA_BASIC_STRING and BOOST_HANA_AUTO_STRING - Added user defined literal _s for basic_string if BOOST_HANA_CONFIG_ENABLE_BASIC_STRING_UDL directive is defined. - Added following integral_constant type aliases. wchar_, char16_, char32_, basic_char - Added following integral_constant constants. wchar_c, char16_c, char32_c, basic_char_c - Added unit test codes for basic_string and wstring.
4c0fccf
to
486d0d5
Compare
Hello,
I wanted to use hana::wstring but couldn't find. So, I tried to make it.
Could you please check it out?
EDIT: 2019-03-12
I have tried various work around to pass the Travis test for clang 3.5, but it can't.
/home/travis/build/yamasdais/hana/include/boost/hana/basic_string.hpp:116:20: error: no matching function for call to 'prepare_impl'
return prepare_impl<CastChar<CharTo, CharFrom>>(
/home/travis/build/yamasdais/hana/include/boost/hana/basic_string.hpp:108:9: note: candidate template ignored: substitution failure [with Cast = boost::hana::basic_string_detail::CastChar<wchar_t, wchar_t>, S = tmp, N = <0, 1, 2, 3>]: non-type template argument is not a constant expression
prepare_impl(S, std::integer_sequence<std::size_t, N...>)
If anyone has a good idea, please help me.
Regards,