Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/basic string #427

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yamasdais
Copy link

@yamasdais yamasdais commented Dec 2, 2018

Hello,

I wanted to use hana::wstring but couldn't find. So, I tried to make it.
Could you please check it out?

  • Added hana::basic_string
  • Added hana::wstring as hana::basic_string<wchar_t>
  • Added tests for hana::basic_string<> and hana::wstring.

EDIT: 2019-03-12
I have tried various work around to pass the Travis test for clang 3.5, but it can't.
/home/travis/build/yamasdais/hana/include/boost/hana/basic_string.hpp:116:20: error: no matching function for call to 'prepare_impl'
return prepare_impl<CastChar<CharTo, CharFrom>>(
/home/travis/build/yamasdais/hana/include/boost/hana/basic_string.hpp:108:9: note: candidate template ignored: substitution failure [with Cast = boost::hana::basic_string_detail::CastChar<wchar_t, wchar_t>, S = tmp, N = <0, 1, 2, 3>]: non-type template argument is not a constant expression
prepare_impl(S, std::integer_sequence<std::size_t, N...>)

If anyone has a good idea, please help me.

Regards,

@ricejasonf
Copy link
Collaborator

Hi. It looks like you need to rebase onto the develop branch. Also commits should be squashed into a single commit (Item 5 in https://github.com/boostorg/hana/blob/master/CONTRIBUTING.md)

@yamasdais
Copy link
Author

Hi. Thank you for the comment.
I'll give it a try

@yamasdais yamasdais force-pushed the feature/basic_string branch from 71f83c3 to 70038ed Compare March 2, 2019 07:33
@yamasdais
Copy link
Author

I renewed the branch from the 'develop branch' a single commit.

Regards,

@ricejasonf
Copy link
Collaborator

ricejasonf commented Mar 2, 2019

Try this:

  1. Make a new branch off of the latest develop @ 4536973
  2. Add your commit
    • git cherry-pick 70038edbee2fe877caf051352d6b92e75279d7d3
  3. Force push to your original branch on the remote
    • git push --force <remote> <new branch>:feature/basic_string

I did not try step 3 myself, but it should update this PR to have only your commit.

EDIT: FWIW I don't know how much of an issue the weird commits are, and I am not the one who will accept the PR anyways.

@yamasdais yamasdais force-pushed the feature/basic_string branch from 70038ed to 4c0fccf Compare March 2, 2019 23:00
@yamasdais
Copy link
Author

I learned git operations I have never used these few days 😃

$ git checkout -b feature/basic_string_pr1 upstream/develop
$ git log --oneline | head -1
4536973 [Travis] Fix build with Clang 7
$ git cherry-pick 70038edbee2fe877caf051352d6b92e75279d7d3
$ git push --force origin feature/basic_string_pr1:feature/basic_string

It seems a `clean' commit you might expected.
Thank you for the advice, anyway.

    - Added classes basic_string and wstring.
    - Added macros BOOST_HANA_BASIC_STRING and BOOST_HANA_AUTO_STRING
    - Added user defined literal _s for basic_string if
          BOOST_HANA_CONFIG_ENABLE_BASIC_STRING_UDL directive is defined.
    - Added following integral_constant type aliases.
	  wchar_, char16_, char32_, basic_char
    - Added following integral_constant constants.
          wchar_c, char16_c, char32_c, basic_char_c
    - Added unit test codes for basic_string and wstring.
@yamasdais yamasdais force-pushed the feature/basic_string branch from 4c0fccf to 486d0d5 Compare March 11, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants