substitute combinator #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not compile on the Windows Visual Studio according to the CI. I was able to track down some of these issues by testing more compilers on Ubuntu and checking for warnings, but other issues remain. I don't have a good way of debugging these problems, so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the substitute combinator as described in #192.
The implementation is nearly identical to the implementation of compose/flow. I tried a few times to have them share code, but I ran into various template parameter problems.
Lines 61 and 74 of the
substitute.hppfile are commented out. They don't appear to be necessary, but are present in the compose/flow files. I think I should either leave them it, or remove them from all the files. I'm not sure which.