Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gregorian.cpp #1

Closed
wants to merge 1 commit into from
Closed

Update gregorian.cpp #1

wants to merge 1 commit into from

Conversation

chris5287
Copy link

"sun" has been redefined, when this is a vital define for detecting Solaris. Renamed variable to sunday and removed redefine.

@chris5287
Update gregorian.cpp
ae348b9 
"sun" has been redefined, when this is a vital define for detecting Solaris. Renamed variable to sunday and removed redefine.
@chris5287
Copy link
Author

Any chance on this being reviewed/merged?

artyom-beilis referenced this pull request Oct 15, 2015
@artyom-beilis
POSIX backed support on FreeBSD
b7fcbdc
@faithandbrave
Copy link

This issue fixed? The issue is listed to Boost 1.60.0 release-note.
https://github.com/boostorg/website/blob/master/feed/history/boost_1_60_0.qbk

@artyom-beilis
Copy link
Member

Can you remind me which issue?
This one: eb8cc39bc18813928cc800fb238861bd99ef8bb4 Or something else?

This issue fixed? The issue is listed to Boost 1.60.0 release-note.
https://github.com/boostorg/website/blob/master/feed/history/boost_1_60_0.qbk—
Reply to this email directly or view it on GitHub.

@faithandbrave
Copy link

Thank you @artyom-beilis .
The issue status is now open .
If you fixed the issue, you should close the issue.

@artyom-beilis
Copy link
Member

Yes you right... it was forgtten due to long testing cycle of regression tests. Artyom Beilis 

  From: Akira Takahashi <notifications@github.com>

To: boostorg/locale locale@noreply.github.com
Cc: Artyom Beilis artyomtnk@yahoo.com
Sent: Thursday, November 12, 2015 7:33 AM
Subject: Re: [locale] Update gregorian.cpp (#1)

Thank you @artyom-beilis .
The issue status is now open .
If you fixed the issue, you should close the issue.—
Reply to this email directly or view it on GitHub.

@artyom-beilis
Copy link
Member

Already fixed

@Pryancito Pryancito mentioned this pull request Nov 17, 2018
Closed
@itprofn itprofn mentioned this pull request Feb 18, 2024
Closed
Flamefire added a commit that referenced this pull request Jul 3, 2024
@Flamefire
Use only UBSAN for macos
535115c 
Adress sanitizer has a false positive in the OS library code:
> strfmon_l(buf, sizeof(buf), lreal, "%i", 1043.34) /* char buf[64];
Leads to:
 READ of size 10 at 0x6020000002bf thread T0
    #0 0x10ab9f54e in wrap_memcpy+0xf8e (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x2854e)
    #1 0x7ff803d22c6f in _strfmon+0x7f8 (libsystem_c.dylib:x86_64+0x74c6f)
    #2 0x7ff803d2323c in strfmon_l+0x9a (libsystem_c.dylib:x86_64+0x7523c)
    #3 0x10a4ead3e in void test_by_char<char>(std::__1::locale const&, _xlocale*)+0x1cce (test_posix_formatting:x86_64+0x100008d3e)

0x6020000002bf is located 0 bytes after 15-byte region [0x6020000002b0,0x6020000002bf)
allocated by thread T0 here:
    #0 0x10ac546e0 in wrap_malloc+0xa0 (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0xdd6e0)
    #1 0x7ff803d22a55 in _strfmon+0x5de (libsystem_c.dylib:x86_64+0x74a55)
    #2 0x7ff803d2323c in strfmon_l+0x9a (libsystem_c.dylib:x86_64+0x7523c)
    #3 0x10a4ead3e in void test_by_char<char>(std::__1::locale const&, _xlocale*)+0x1cce (test_posix_formatting:x86_64+0x100008d3e)
Flamefire added a commit that referenced this pull request Jul 3, 2024
@Flamefire
GHA: Use only UBSAN for macos
9c37216 
Adress sanitizer has a false positive in the OS library code:
> strfmon_l(buf, sizeof(buf), lreal, "%i", 1043.34) /* char buf[64];
Leads to:
 READ of size 10 at 0x6020000002bf thread T0
    #0 0x10ab9f54e in wrap_memcpy+0xf8e (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x2854e)
    #1 0x7ff803d22c6f in _strfmon+0x7f8 (libsystem_c.dylib:x86_64+0x74c6f)
    #2 0x7ff803d2323c in strfmon_l+0x9a (libsystem_c.dylib:x86_64+0x7523c)
    #3 0x10a4ead3e in void test_by_char<char>(std::__1::locale const&, _xlocale*)+0x1cce (test_posix_formatting:x86_64+0x100008d3e)

0x6020000002bf is located 0 bytes after 15-byte region [0x6020000002b0,0x6020000002bf)
allocated by thread T0 here:
    #0 0x10ac546e0 in wrap_malloc+0xa0 (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0xdd6e0)
    #1 0x7ff803d22a55 in _strfmon+0x5de (libsystem_c.dylib:x86_64+0x74a55)
    #2 0x7ff803d2323c in strfmon_l+0x9a (libsystem_c.dylib:x86_64+0x7523c)
    #3 0x10a4ead3e in void test_by_char<char>(std::__1::locale const&, _xlocale*)+0x1cce (test_posix_formatting:x86_64+0x100008d3e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris5287 @faithandbrave @artyom-beilis