Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of deprecated macros #10

Closed
wants to merge 1 commit into from
Closed

Conversation

mclow
Copy link

@mclow mclow commented Sep 11, 2015

In Boost 1.51 the macros BOOST_NO_CHAR16_T and BOOST_NO_CHAR32_T were deprecated, and the replacements BOOST_NO_CXX11_CHAR16_T and BOOST_NO_CXX11_CHAR32_T wee introduced.

I would like to remove the deprecated macros, so this change uses them instead of the old names.

No functionality change.

@mclow
Copy link
Author

mclow commented Oct 13, 2015

Ping?

@artyom-beilis
Copy link
Member

It is little bit complicated than that.

  • I need to check that every relevant header/source includes config.
  • I need to check that stuff actually works

Last time I tested C++11 char16/32_t support was exceptionally poor - not only characters
required but also relevant std::locale facets - which are usually the problem.

Probably I'll need to go to internal boost-locale char16/32 config.

@mclow
Copy link
Author

mclow commented Oct 14, 2015

The only change here is to use a different macro - and the two were defined to be the same (and I'm pretty sure that they come from the same header).

@artyom-beilis
Copy link
Member

It is opt-in vs opt-out case

I need to test it deeply before doing the change - mostly make sure the config is correct.

It is in my TODO list for near future

@artyom-beilis
Copy link
Member

As I thought - the "replacement" macros are for no
use for Boost.Locale

Boost.Locale needs both having these characters
and having standard library support for them
like std::num_punct facet, etc.

The problem is that it is defined in compiler config
and it does not answer on library issue.

Trying to build Boost.Locale with "updated" in C++11 mode
macros cause multiple issues due to missing facet

So I replaced the macros with BOOST_LOCALE_ENABLE_CHAR(16|32)_T
that can be defined by user if he wants to try C++11 support

So deprecated macro was removed but the alternative
isn't suitable replacement at all.

Artyom Beilis

The only change here is to use a different macro - and
the two were defined to be the same (and I'm pretty
sure that they come from the same header).>—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants