Fix invalid static_cast. #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is also included in #9. |
|
Indeed! I'm closing this in favor of the better explained and executed #9. (This PR is kind of hacked together.) |
|
Ok... the problem is that the code that used unordered_map had never actually was used due to a simple fact that version.hpp wasn't included and it never got to be compiled. I consider removing entire unordered part as it was never properly tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in https://svn.boost.org/trac/boost/ticket/11673 ("Invalid static_cast"). All regression tests pass. In case you want a PR against master, see my branch "master".