-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ccmath support detection. #1046
Conversation
See discussion in #1045.
This post confirms that this fixes the client code which first detected the issue discussed toward to bottom of #1045. Thank you so much John (@jzmaddock) for such a quick response to even this trivial issue! |
Should we apply this logic to all of the headers? Isfinite has the old logic, and some have none at all. |
This is, indeed, a slim area, ... Clients using MSVC language standard 14 or lower. Anyway, I think that seems sensible both to repair it and to repair it consistently. For more information, by sheer random chance, I was revitalizing a very old legacy project recently and just so happened to have MSVC 141 C++ standard 14 running on CI (otherwise I would not have seen this at all...). Anyway, the error message(s) I got were here. There are errors on |
Hi Matt (@mborland) I was thinking about this issue and noticed C++17 is not so far away from C++14 (the language standard supported by all of Math/Multiprecision). I suppose you won't really like this question but, ...
|
It's not particularly far away from C++14, but that is not the pressing issue. For it to work we require proper |
Understood. Challenging, getting through the maze of compilers... |
This is now creeping into CI on some standalone. Maybe more but that's all I saw at a quick glance. |
WTF? Nothing has changed, either here, or in boostdep or Boost.Format... rerunning just to see what happens! |
If it runs, you might have hit something that I've always wondered about, non-atomic checkins in the modular-boost. I wonder if something like that might have happened? Let's see. I don't even know if commits to the master project or develop are atomic. That would surprise me... |
The thing is still looking for This file is present in 1.83. I wonder if this header has been either knowingly or mistakenly removed from Boost on Develop in preparation for 1.84? |
In short, add |
Awesome! Thanks John and Matt |
It is running perfectly in the field on my unrelated project that actually uses it on MSVC |
See discussion in #1045.