Update geometric.hpp

[kenarab]

The proposal is derived from this issue

#1126

This line should be corrected
At /math/distributions/geometric.hpp at line 404

  return std::log(p); // success_fraction
      

Now the code is

  return log(p); // success_fraction
      

When building that library. Throws this error

In file included from /opt/homebrew/include/boost/math/distributions.hpp:26:
/opt/homebrew/include/boost/math/distributions/geometric.hpp:404:16: error: unexpected namespace name 'log': expected expression
        return log(p); // success_fraction
               ^
1 error generated.
make[2]: *** [CMakeFiles/PonisIqCoreNLV.dir/Unity/unity_0_cxx.cxx.o] Error 1
make[1]: *** [CMakeFiles/PonisIqCoreNLV.dir/all] Error 2
make: *** [all] Error 2

[mborland]

log should be found by ADL for any RealType. The correct fix would be adding using std::log; under this line: https://github.com/boostorg/math/blob/develop/include/boost/math/distributions/geometric.hpp#L386. I think it also needs a using std::exp;.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (28a5ffb) to head (1303786).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1127      +/-   ##
===========================================
+ Coverage    93.69%   93.71%   +0.01%     
===========================================
  Files          770      770              
  Lines        61057    61057              
===========================================
+ Hits         57209    57221      +12     
+ Misses        3848     3836      -12     

Files	Coverage Δ
include/boost/math/distributions/geometric.hpp	89.28% <ø> (ø)

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a5ffb...1303786. Read the comment docs.

[mborland]

macOS clang failures are being addressed elsewhere