nonfinite_num_get facet fix: honor "legacy" flag to enable "nanq"+"nans" #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did this slip through the cracks? I have really no understanding of what this code does. @jzmaddock : Could you take a look as well? |
|
Looks right to me, we should merge once CI completes. Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hopefully obvious one-line fix to "Facets for Floating-Point Infinities and NaNs".
The documentation states that the "legacy" flag enables support for "nanq" and "nans", but any other flag is not supposed to do so.
The "legacy" flag got lost in 16c57be "Fixes for compile tests", but the affected code was broken from the very beginning.