Fix build on platforms with "double-double" long double type #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 01f3b7d most tests started to fail on platforms that use a "double-double" for long double, like powerpc64le: ../../../boost/math/tools/precision.hpp:148:137: error: expected primary-expression before ‘long’ 148 | inline constexpr long double epsilon<long double>(const std::true_type& BOOST_MATH_APPEND_EXPLICIT_TEMPLATE_TYPE(long double)) noexcept(long double) ../../../boost/math/tools/precision.hpp:148:137: error: expected ‘)’ before ‘long’ 148 | inline constexpr long double epsilon<long double>(const std::true_type& BOOST_MATH_APPEND_EXPLICIT_TEMPLATE_TYPE(long double)) noexcept(long double) ../../../boost/math/tools/precision.hpp:148:137: error: expected initializer before ‘long’ 148 | inline constexpr long double epsilon<long double>(const std::true_type& BOOST_MATH_APPEND_EXPLICIT_TEMPLATE_TYPE(long double)) noexcept(long double) Fix this by replacing the noexcept expression with the contents of BOOST_MATH_NOEXCEPT, which was the intention of commit 01f3b7d.
mborland
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
@jzmaddock This change looks good to me; fixes an error that I introduced.
|
Hi @mscastanho this is nice. Thanks for investigating this phenomenon. @mborland and @jzmaddock I took the liberty of approving the CI run. |
|
Added note. We are still a long ways away, but work to implement double-double BSL backend is underway in the 2021 GSoC here |
|
This looks good to go. Should probably make it into #661. |
|
Being somewhat pedantic: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 01f3b7d most tests started to fail on platforms that use a
"double-double" for long double, like powerpc64le:
Fix this by replacing the noexcept expression with the contents of
BOOST_MATH_NOEXCEPT, which was the intention of commit 01f3b7d.