Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 833 #835

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Fix Issue 833 #835

merged 4 commits into from
Oct 7, 2022

Conversation

jzmaddock
Copy link
Collaborator

No description provided.

To match what Mathematica does.
Fixes: #829
Fixes issue with 1F1[-n, n, n].
Also reduce cancellation error in a = -1 special case.
Fixes #833.
# Conflicts:
#	test/test_1F1.hpp
@ckormanyos ckormanyos mentioned this pull request Oct 6, 2022
@jzmaddock jzmaddock merged commit 9346271 into develop Oct 7, 2022
@@ -356,6 +356,40 @@ void test_spots6(T, const char* type_name)
{ { -28, -28, 23.5, SC_(1.3636649055777180973706533952884087e10) } },
{ { -29, -29, 23.5, SC_(1.4288921731123489919940015692546766e10) } },
{ { -30, -30, 23.5, SC_(1.4799868660144765261156243055282531e10) } },
//
// Special cases for 1F1[-n, n, n], recurrence relations explode for these
// so we need to take special care, see:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there supposed to be something after "see:"?

@NAThompson NAThompson deleted the issue833 branch January 24, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants