Fix for scipy issue 17146 #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
jzmaddock
reviewed
Oct 24, 2022
| if (k == 0) | ||
| { // binomial coeffic (n 0) = 1, | ||
| // n ^ 0 = 1 | ||
| return pow(1 - dist.success_fraction(), n); |
There was a problem hiding this comment.
Thanks for taking this on Matt, and with apologies for being AWOL: I'm just catching up with everything while writing the release notes for 1.81.
Since ibeta_derivative is relatively heavyweight, and the alternative formula is so simple, I think it would be nice to have retained the alternative form here. The trick would be to take logs and use exp(n*log1p(-dist.success_fraction())) in the case where - dist.success_fraction() is small. Maybe try 0.125 as a cutoff? Might need some experimenting to see where the errors start to rise.
This can certainly wait till after the next release though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: scipy/scipy#17146