-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional architecture testing to drone #868
Conversation
Cool, I hadn't realised we had that facility! |
@sdarwin Do you see my error in adding M1? It's mostly copy-paste from the slack channel but I am getting the error |
@mborland the first argument 'job name' must be unique. Change to |
[ci skip]
[ci skip]
[ci skip]
@jzmaddock This seems to be working now, but produced some errors in
Interestingly, I can't reproduce any of the errors on my M1 machine. @NAThompson are you able to reproduce? |
@mborland : I'm going to extract the s390x logic out of this to a separate PR as that's the closest to being green, and then we should go from there. |
@mborland : do we need to revisit running M1 tests? I'm sure I'm missing something, but I'm not seeing what makes these tests run on M1? |
Now that you have ARM working I think it would be easy to add. It is generally this line:
The macOS machines in drone are supposed to be M1. |
While the macOS machines are m1, it seems the OS can simulate x86 or use the native arm architecture. The drone process appears to be using x86 so I need to work on fixing that. |
That makes sense because I was getting failures from CI that I could not reproduce locally on my M1 machine. Thanks. |
Switched m1 drone to arm64. Try it again. |
@jzmaddock It looks like M1 is good to go as well now. Merging. |
No description provided.