-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S390x testing #908
S390x testing #908
Conversation
!!!REVERT THIS COMMIT BEFORE MERGING!!!
Mostly failures in testing data not having enough accuracy.
OK folks, this PR has fixed very nearly all the 128-bit long double related issues, nearly all so far have been testing-related rather than library related which is good. @mborland , @NAThompson I wonder if I can draw your attention to the following last few failures, even hints on where to start looking would be useful: whittaker_shannon_test has a very large number of errors of the order 10^-25 which is 7162055944ULP which seems to be too large to ignore. In logs at https://drone.cpp.al/boostorg/math/1080/27/2 daubechies_scaling_test has errors of the order of 10^8ULP but only with 19 vanishing moments? See log https://drone.cpp.al/boostorg/math/1080/27/2 test_autodiff_2 and test_autodiff_3 have error rates that suggest truncation to double somewhere, but I simply don't know where to start looking: https://drone.cpp.al/boostorg/math/1080/38/2 Thanks! |
OK in daubechies_scaling_test here: math/test/daubechies_scaling_test.cpp Line 291 in 346d2a9
|
Nothing stands out to me as to why these have such high error. @pulver may be able to speak more intelligently to autodiff. |
The 28 autodiff errors can be classified into 4 subsets that should have straight-forward fixes:
|
The autodiff tests are all green now; only interpolators remains. |
Whew, this is all green now. @mborland @NAThompson any reason not to go ahead and squash and merge? Any pending PR's likely to conflict with this? |
I have no issues with this being merged. |
OK good, merged. |
No description provided.