Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally Disable MP Testing #965

Merged
merged 6 commits into from
Mar 7, 2023
Merged

Conditionally Disable MP Testing #965

merged 6 commits into from
Mar 7, 2023

Conversation

mborland
Copy link
Member

@mborland mborland commented Mar 6, 2023

Should significantly reduce resource usage. Changes a macro used for testing under standalone so now you have to explicitly enable MP testing.

@jzmaddock
Copy link
Collaborator

Could we enable MP-testing for at least ONE compiler in CI? Otherwise I fear breakages will go unnoticed.

@mborland
Copy link
Member Author

mborland commented Mar 6, 2023

Could we enable MP-testing for at least ONE compiler in CI? Otherwise I fear breakages will go unnoticed.

Yes. Once the drone run finishes I will see what the delta in our resource usage is. If we need to whack testing down more I can continue to sprinkle that macro around, and then define it in a few CI runs.

@jzmaddock
Copy link
Collaborator

Yes. Once the drone run finishes I will see what the delta in our resource usage is. If we need to whack testing down more I can continue to sprinkle that macro around, and then define it in a few CI runs.

Got it, cool. I suspect the multiprc_concept_check_N tests are probably the worst offenders for memory usage.

@mborland
Copy link
Member Author

mborland commented Mar 6, 2023

Yes. Once the drone run finishes I will see what the delta in our resource usage is. If we need to whack testing down more I can continue to sprinkle that macro around, and then define it in a few CI runs.

Got it, cool. I suspect the multiprc_concept_check_N tests are probably the worst offenders for memory usage.

Those do look aggressive. The changes to quadrature dropped the CI run time for that test suite by ~20%.

@mborland mborland changed the title Disable MP testing in quadrature Conditionally Disable MP Testing Mar 6, 2023
@mborland
Copy link
Member Author

mborland commented Mar 6, 2023

@jzmaddock I appreciate your comment in test_1F1 that: These next 2 tests take effectively "forever" to compile with clang:

@mborland mborland linked an issue Mar 7, 2023 that may be closed by this pull request
@mborland
Copy link
Member Author

mborland commented Mar 7, 2023

The two CI failures in drone are spurious.

@mborland mborland merged commit 2fe1fac into develop Mar 7, 2023
@mborland mborland deleted the quad branch March 7, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excesive test compile resources.
2 participants