Refactor/backmp11: HandledEnum, normalize event & MSVC workaround #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace remaining occurrences of HandledEnum and use bit operations.
chandryan
changed the title
Replace process_event callback in compile policy impls with normalize_event methods for better re-usage and readability.
chandryan
force-pushed
the
refactor/backmp11-normalize-event
branch
from
cad4cf7 to
6ca2aa5
Compare
chandryan
force-pushed
the
refactor/backmp11-normalize-event
branch
from
3ddfb66 to
3a109c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied refactorings:
HandledEnumwithprocess_resultprocess_resultfor better readabilityprocess_eventcallback "ping-pong" with anormalize_eventfunction for better readabilityfavor_runtime_speedpolicy, as MSVC seems to be able to handle the optimized way after the fix of event deferral was applied