Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

any_connection stream customization #195

Closed
anarthal opened this issue Dec 20, 2023 · 1 comment
Closed

any_connection stream customization #195

anarthal opened this issue Dec 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@anarthal
Copy link
Collaborator

The new any_connection doesn't allow custom Stream types - it always uses detail::variant_stream. I'm not sure whether this is really required, since this stream is designed to cover almost all real use cases.

If your use case doesn't fit the default stream, please comment in this issue.
@anarthal anarthal added the enhancement New feature or request label Dec 20, 2023
@anarthal anarthal mentioned this issue May 9, 2024
Merged
anarthal added a commit that referenced this issue May 10, 2024
@anarthal
any_stream->engine, asio::coroutine ODR violation fix
77de54c 
Fixed a potential ODR violation with `asio::coroutine` under MSVC, manifesting as sporadic test failures under release configurations.
`any_stream` has been replaced by the internal `EngineStream` concept
and the `engine` interface.
`algo_runner` has been replaced by `top_level_algo`, improving algorithm
type-erasing

This change is required by #195 and beneficial for #75
close #259
@anarthal
Copy link
Collaborator Author

I strongly believe allowing this is a mistake. If you strongly need this, please comment.

@anarthal anarthal closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anarthal