Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits: the write buffer may surpass max_buffer_size #297

Closed
anarthal opened this issue Jun 30, 2024 · 0 comments · Fixed by #325
Closed

Limits: the write buffer may surpass max_buffer_size #297

anarthal opened this issue Jun 30, 2024 · 0 comments · Fixed by #325
Labels
enhancement New feature or request

Comments

@anarthal
Copy link
Collaborator

In #278 we implemented a check to make write operations fail if they attempt to write packets bigger than max_buffer_size. However, this is checked after the buffer is resized. This yields the correct user-facing behavior, but doesn't actually constrain memory. The correct implementation is a little bit more involved, and should go together with #279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant