Fix missing include #147
Merged
Fix missing include #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows-latest was moved to windows-2022 which does not have VS 2019
Also add test of this in combination with WIN32_LEAN_AND_MEAN. Checks for missing includes, such as shellapi.h
CommandLineToArgvW is defined in shellapi.h not windows.h although the former is usually included by the latter unless e.g. WIN32_LEAN_AND_MEAN is defined.
Codecov Report
@@ Coverage Diff @@
## develop #147 +/- ##
========================================
Coverage 99.33% 99.33%
========================================
Files 33 33
Lines 3001 3001
========================================
Hits 2981 2981
Misses 20 20
|
github-actions bot
pushed a commit
that referenced
this pull request
Mar 6, 2022
Add missing include: shellapi.h'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing include:
shellapi.hCommandLineToArgvWis defined inshellapi.hnotwindows.halthough the former is usually included by the latter unless e.g.WIN32_LEAN_AND_MEANis defined.