-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests #151
Merged
Merged
Improve tests #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine the with and without Boost.Filesystem cases into 1 test
Codecov Report
@@ Coverage Diff @@
## develop #151 +/- ##
========================================
Coverage 99.33% 99.34%
========================================
Files 33 33
Lines 3021 3051 +30
========================================
+ Hits 3001 3031 +30
Misses 20 20
|
Based on code reported at boostorg#150
Some modes seem to be incompatible with certain CI environments, e.g. newer Appveyor images making test fail sometimes. Set a known "good" mode to avoid this.
This enables e.g. the std::filesystem::path traits test
Creating console input events fails sporadically on recent Appveyor images when using CMake/CTest. Add an option to disable that and use it for the recent Appveyor image
It incorrectly returned 0 instead of -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filebuf::sync()
when fflush failsCloses #150