Fix CI && Resolve review && improve docs

boostorg · Nov 25, 2023 · 1ed697a · 1ed697a
1 parent 66cb535
commit 1ed697a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/example/quick_examples.cpp b/example/quick_examples.cpp
@@ -112,6 +112,8 @@ void test_examples() {
 //[pfr_quick_examples_get_name
     // Get name of field by index
 
+    // Keep in mind that it's unportable code
+    // You should move this structure somewhere outside of function scope
     struct sample {
         int f1;
         long f2;

diff --git a/include/boost/pfr/detail/core_name20_static.hpp b/include/boost/pfr/detail/core_name20_static.hpp
@@ -167,7 +167,7 @@ consteval auto name_of_field() noexcept {
         && std::string_view{
             detail::name_of_field_impl<
                 core_name_skip, detail::make_clang_wrapper(std::addressof(
-                    fake_object<core_name_skip>().size_at_begin
+                    detail::fake_object<core_name_skip>().size_at_begin
                 ))
             >().data()
         } == "size_at_begin",

diff --git a/include/boost/pfr/detail/fake_object.hpp b/include/boost/pfr/detail/fake_object.hpp
@@ -13,6 +13,7 @@
 #pragma once
 
 #include <boost/pfr/detail/config.hpp>
+
 namespace boost { namespace pfr { namespace detail {
 
 // This variable serves as a compile-time assert. If you see any error here, then

diff --git a/test/core_name/print_name.cpp b/test/core_name/print_name.cpp
@@ -29,7 +29,7 @@ using namespace boost::pfr;
 template <class T, std::size_t I>
 inline constexpr auto no_check_stored_name_of_field = detail::name_of_field_impl<T,
     detail::make_clang_wrapper(std::addressof(detail::sequence_tuple::get<I>(
-        detail::tie_as_tuple(detail::fake_object<T>)
+        detail::tie_as_tuple(detail::fake_object<T>())
     )))
 >();