Allow object_pool::construct() to use variadic template, if available. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeking3 Sorry to bug you, but do you see this PR as ready to merge? If no: What else do I need to do? I'm currently always copy&pasting it into my projects; would love to see it make its way into the official distribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @jbherdman suggested I'm opening a new pull request with all of their changes in one commit. Hopefully, we get an accurate Code Coverage Report that way.
This PR doesn't contain any new code that wasn't already included in PR 31.
Fixes issue #22, with a fallback to the existing code for compilers that don't support variadic-templates.