Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify no wstreambuf support. #282

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Simplify no wstreambuf support. #282

merged 1 commit into from
Aug 23, 2023

Conversation

jzmaddock
Copy link
Contributor

See #224.

@jzmaddock
Copy link
Contributor Author

@robertramey : Looks like the CI is stalled indefinitely waiting for a runner - that's because the ubuntu-18 image has been deprecated (for example) and available runners are stupidly scarce. Shall I update the images used as part of this PR? The catch is that older gcc versions will no longer be available. They are available with the drone CI runners that the cpp alliance provides for us though...

@robertramey
Copy link
Member

robertramey commented Apr 30, 2023 via email

@robertramey robertramey closed this May 1, 2023
@robertramey
Copy link
Member

looking more carefully at the PR I find a number of statements similar to the following:

[ test-bsl-run_files test_helper_support : : : [ requires std_wstreambuf ] ]

OK. But when I look at the source for test_helper_support , I don't see any reference to wide streams or wchar or anything else related. Why is the "requires" statement required here specifically? How does one know whether it's going to be needed or not?

@robertramey robertramey reopened this May 2, 2023
@jzmaddock
Copy link
Contributor Author

@robertramey, I added the requirement to all of the tests which had linker errors when building the tests with -DBOOST_NO_STD_LOCALE. Basically anything which used the xml_archives anywhere.

@ArielSilver
Copy link

ArielSilver commented Jul 18, 2023

**solution of this, ### boost serialization can not be sc stoped in windows platform #283

**


`struct base {
virtual std::string get_name () {
return STRUCT_STR(base);
}
template
void serialize(Archive &ar, const int version) {
}
};

struct A : public base {
virtual std::string get_name () {
return STRUCT_STR(A);
}
template
void serialize(Archive &ar, const int version) {
ar & boost::serialization::base_object(*this);
}
};

struct B : public A {
B(int _e) {e = _e;}
B() {}
virtual std::string get_name () {
std::cout << e;
return STRUCT_STR(B);
}

template<class Archive>
void serialize(Archive &ar, const int version) {
    ar & boost::serialization::base_object<A>(*this);
    ar & e;
    ar & p;
}

int e;
ProcessStatus p = UNINITIALIZED;
};

void register_oa_class_type(boost::archive::text_oarchive& oa) {
oa.register_type();
oa.register_type();
oa.register_type();
}

void register_ia_class_type(boost::archive::text_iarchive& ia) {
ia.register_type();
ia.register_type();
ia.register_type();
}`

@robertramey robertramey reopened this Aug 23, 2023
@robertramey robertramey merged commit f3c564c into develop Aug 23, 2023
0 of 15 checks passed
pdimov added a commit that referenced this pull request Aug 28, 2023
robertramey added a commit that referenced this pull request Nov 1, 2023
* develop: (108 commits)
  removed unordered tests
  tests have been taken over by developers of boost unordered
  uploading changes regarding unordered ... uploading tweaks to CMakeLists.txt so accommodate static linking
  imported/implemented boost/serialization/variant  and test_variant
  Remove serialization support from Boost.Unordered containers
  Fix invalid vptr access in extended_type_info_no_rtti constructor
  Fix invalid downcast in ~xml_oarchive_impl
  altered boost optional to depend only public interface functions declared in std::optional. adjusted test_optional to test serialization of both boost::optional and std::optional
  Revert "Add serialization for std::optional"
  fix new requirement - if assigment is not defaulted, copy can't be either
  Fix clang-cl regression introduced by #282
  correction in previous merge
  Remove debug output from util/test.jam
  Fix Sub::operator== signature to avoid ambiguity errors in C++20
  Remove C++03 from GHA, because Variant and LexicalCast no longer compile under C++03
  incremement archive version number fix PR 274 fix PR 283
  committing most pending PRs
  Replace static_cast with reinterpet_cast in interface_oarchive
  Update xml_escape::fill() to default assign bstart, bend to an empty string
  Use the first instance of bos during serialization (for the case when there are multiple instances)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants