Remove ::boost::test_tools::tt_detail::dummy_cond #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace loops using it by simple do { ... } while (0) loops.
This allows static analysis tools like clang-tidy to better understand
the code and avoid false positives.
Fixes #343.
jonesmz
approved these changes
Oct 4, 2024
I merge in develop to kick off a CI run to validate. The changes look like they should be OK. |
mborland
approved these changes
Oct 4, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Dec 5, 2024
This change switches to the latest IWYU 0.23, which is compatible with Clang 19. Fixed new "modernize-use-starts-ends-with" warnings. The new "bugprone-use-after-move" warning in `result_tests.cpp` is a false positive caused by a bug in Boost.Test versions < 1.87. This has been addressed by introducing a local variable. See upstream references: - Issue: boostorg/test#343 - Fix: boostorg/test#348 Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace loops using it by simple do { ... } while (0) loops.
This allows static analysis tools like clang-tidy to better understand
the code and avoid false positives.
Fixes #343.