Fix undefined behavior in basic_cstring::rfind
#360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will now create a static `CharT[]` array and return that by reference as-if `"foo"` was used instead of `LITERAL("foo")`
Getting the pointer to 1-before an array is undefined behavior, i.e. `begin() - 1` is not allowed. So modify `rfind` to loop until the front and do a final comparison with `begin()/first` afterwards before returning `npos`. Use a better-suited for-loop and modify `find` to look as similar as possible so the difference is easy to spot. Fixes boostorg#357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the pointer to 1-before an array is undefined behavior, i.e.
begin() - 1is not allowed.So modify
rfindto loop until the front and do a final comparison withbegin()/firstafterwards before returningnpos.Use a better-suited for-loop and modify
findto look as similar as possible so the difference is easy to spot.Fixes #357