This repository has been archived by the owner on Feb 27, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 95
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The multi-hypervisor refactor lost the ssh key creation code.
- Loading branch information
1 parent
22b11f1
commit d7b0e1b
Showing
2 changed files
with
25 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7b0e1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So key creation is missing in the 1.2.0 release, correct? I just installed from Homebrew on a brand new system and found
boot2docker init
broken out of the box.brew install boot2docker --HEAD
to include this change has fixed it. Bumping a release for distribution seems like a considerate move 😔d7b0e1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the key creation code is not missing from 1.2.0 - if you download the boot2docker v1.2.0 release, you'll see its based on
Git commit: a551732
, which if you review https://github.com/boot2docker/boot2docker-cli/commits/master is the merge that contains this code.I am however a little puzzled by the v1.2.0 git tag - which doesn't include it, which may be what is throwing off brew?
d7b0e1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and now I've forced the tag - if you know how to get brew to bump a release please do.
d7b0e1b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-reference for anyone who may happen to land here: Homebrew binaries are now rebuilt following the revision tag change. See also boot2docker/boot2docker#509. Thanks Sven!