Deprecate support for --dockerport flag.

[jonseymour]

As the result of long standing issues with support for half-close of inbound
TCP connections to Virtual Box guests on (at least) OSX use of port-forwarded
docker connections should be discouraged.

So, if the user really wants to configure it, let them. Otherwise, don't
set it up in the first place.

See boot2docker issue #150 (and others) for details.

Docker-DCO-1.1-Signed-off-by: Jon Seymour jon.seymour@gmail.com (github: jonseymour)

[tianon]

Seems sane to me, but I defer this one strongly to @SvenDowideit who's played with it the most of the team AFAIK.

[SvenDowideit]

I think its sane too, I just want a little thinking time and there are a few issues where vbox makes a mess of the host-only network atm - and one where b2d doesn't get the ip

[jonseymour]

I just noticed that this pull request will prevent boot2docker ip working properly because the derivation of the ssh port currently assumes that "Forwarding(1)" always contains the ssh port. With this change, the ssh port will be listed as "Forwarding(0)". I'll submit a modified pull request that improves the robustness of the ssh port derivation so that it isn't position sensitive.

[SvenDowideit]

I already made a PR for this yesterday :)

Please review

On 10 July 2014 05:59:00 GMT+10:00, jonseymour notifications@github.com wrote:

I just noticed that this pull request will prevent boot2docker ip
working properly because the derivation of the ssh port currently
assumes that "Forwarding(1)" always contains the ssh port. With this
change, the ssh port will be listed as "Forwarding(0)". I'll submit a
modified pull request that improves the robustness of the ssh port
derivation so that it isn't position sensitive.

---

Reply to this email directly or view it on GitHub:
#153 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

[SvenDowideit]

ok - I'm planning on putting this into v.1.2.0 first week of August.

[jonseymour]

Sven, I have reviewed #185 and seems sane. I've rebased this branch to remove the merge conflicts.

[SvenDowideit]

very awesome :)

[SvenDowideit]

LGTM