-
Notifications
You must be signed in to change notification settings - Fork 95
Create driver model and refactor virtualbox dependencies into driver #184
Conversation
I will look at it in more detail after I get the 1.1.1 b2d release out - very awesome to see though |
can we please not make instead, perhaps we should add a |
I agree with @SvenDowideit that having an explicit |
Thanks for the feedback guys. I brought back the init command. Auto init is now explicit with the newly added --init=true (default false) flag. |
yes, I like it LGTM - @tianon @gmlewis @crosbymichael @steeve I'd love to merge this and then we can keep working on it :) |
LGTM |
@@ -294,8 +325,8 @@ func ListMachines() ([]string, error) { | |||
} | |||
|
|||
// CreateMachine creates a new machine. If basefolder is empty, use default. | |||
func CreateMachine(name, basefolder string) (*Machine, error) { | |||
if name == "" { | |||
func CreateMachine(i *driver.MachineConfig) (*Machine, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nit: I have been encouraged in peer reviews of my own code to reserve variables like i
to be integer index counters for loops... so that others looking at the code are least surprised. So if you agree, you could make this variable mc
or m
. If you want to leave it as is, that's fine with me too.
LGTM after comments addressed. |
Thanks for the code review. @SvenDowideit I have rebased to lastest master. There are three new commits based on @gmlewis feedback. |
Create driver model and refactor virtualbox dependencies into driver
awesome! |
Laying out some foundation work for multi-hypervisor support. Some keys changes include: