This repository has been archived by the owner on Feb 27, 2018. It is now read-only.
Exit on virtualbox initialization error #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a few other cases of |
| @@ -39,7 +39,10 @@ const ( | |||
| ) | |||
|
|
|||
| func init() { | |||
| driver.Register("virtualbox", InitFunc) | |||
| if err := driver.Register("virtualbox", InitFunc); err != nil { | |||
| fmt.Printf("Failed to initialize driver. Error : %s", err.Error()) | |||
There was a problem hiding this comment.
Also, this probably out to either be log.Fatal or use fmt.Fprintf and go to stderr, so we start getting closer to good practices all around in this project. :)
|
I could only find one other instance of |
|
LGTM |
|
(this one's especially for you @tiborvass) |
|
@tianon haha! 👍 |
|
LGTM |
SvenDowideit
pushed a commit
that referenced
this pull request
Aug 11, 2014
Exit on virtualbox initialization error
SvenDowideit
added a commit
to SvenDowideit/boot2docker-cli
that referenced
this pull request
Nov 10, 2014
better automount device detection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor fix to insure that the program does not continue if the call to
driver.Registerreturns a non-nil error.