This repository has been archived by the owner on Feb 27, 2018. It is now read-only.
Starting from saved state skips setUpShares #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,7 +195,9 @@ func (m *Machine) Start() error { | |||
| switch m.State { | |||
| case driver.Paused: | |||
| return vbm("controlvm", m.Name, "resume") | |||
| case driver.Poweroff, driver.Saved, driver.Aborted: | |||
| case driver.Saved: | |||
There was a problem hiding this comment.
Wouldn't this be simpler if you moved it down above the existing startvm line and used fallthrough in the Poweroff/Aborted block? (http://golang.org/ref/spec#Fallthrough_statements)
There was a problem hiding this comment.
you are right, fixed with fallthrough
lalyos
force-pushed
the
start-from-saves-state
branch
from
0d318c9 to
5d389e8
Compare
|
For a reference, until it gets merged a workaround is: |
|
LGTM (untested) |
|
LGTM |
tianon
added a commit
that referenced
this pull request
Oct 22, 2014
Starting from saved state skips setUpShares
SvenDowideit
pushed a commit
to SvenDowideit/boot2docker-cli
that referenced
this pull request
Nov 10, 2014
…n-script-from-init Fix/call opt shutdown script from init
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to start from saved state, virtualbox.setUpShares() fails while running:
The error message gives a hint:
VBoxManage: error: The machine is not mutable (state is Saved)Fixes #292