Skip to content

Move all crates under crates/ #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

Move all crates under crates/ #1413

merged 2 commits into from
Jul 17, 2025
+6 −22

Conversation

cgwalters
Copy link
Collaborator

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project structure by moving all crates into a crates/ subdirectory and updating the workspace Cargo.toml to use a glob for discovering members. My review identified a high-severity issue where readme paths in the individual crates' Cargo.toml files were not updated after the move, which could break documentation and packaging.

@cgwalters cgwalters requested a review from jeckersb July 16, 2025 20:23
@cgwalters cgwalters force-pushed the crates-refactor branch 3 times, most recently from 5b6fee0 to 757f987 Compare July 16, 2025 20:48
@cgwalters
Copy link
Collaborator Author

Note to self and others, run make validate-rust locally before doing PRs like this

@cgwalters cgwalters mentioned this pull request Jul 16, 2025
Merged
1 task
jeckersb
jeckersb approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pushed one minor fix that was erroring in CI. Assuming everything passes, ship it!

@jeckersb
Copy link
Collaborator

Manually rebased, not sure why github was claiming there was conflicts because it rebased just fine 🤷

@cgwalters cgwalters enabled auto-merge July 17, 2025 18:56
@jeckersb
Copy link
Collaborator

jeckersb commented Jul 17, 2025 •
edited
Loading

Hm I think you pushed over my fixup

Edit: to be more specific:

https://github.com/bootc-dev/bootc/compare/8e0c7723e71a0a054382185896e7a72dbea390ad..5fd342e948a99ffc15e6d0911325253e2aaa5a77

@cgwalters
Copy link
Collaborator Author

Thanks! Yes I messed that up, I think I fetched from my branch but forgot to actually reset my local to the remote. Should be fixed now

cgwalters added 2 commits July 17, 2025 16:27
@cgwalters
crates: Drop readme =
8836905 
We don't actually publish any of these so there's no need
for this.
@cgwalters
Move all crates under crates/
2f69a16 
Just organizational cleanup, a number of Rust projects
do this:
https://github.com/search?q=+%22crates%2F*%22+path%3ACargo.toml+-is%3Afork&type=code&p=5

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Collaborator Author

Hmm Github seems to be treating any modifications to a renamed file as a conflict, when the git client definitely is happy to just do the obvious thing and update the new name.

@cgwalters cgwalters merged commit 0f3d02e into bootc-dev:main Jul 17, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeckersb jeckersb jeckersb approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cgwalters @jeckersb