Updates for oci-spec 0.8.2 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n oci-spec from Vec to Option<Vec>. Additionally resolve clippy warnings. Signed-off-by: David Steele <david.steele@alianza.com>
Signed-off-by: David Steele <david.steele@alianza.com>
dsteeley
force-pushed
the
ocispec_update
branch
from
0f24168 to
0a06783
Compare
Collaborator
I think they should have made a semver bump, but that's an argument to have over in youki-dev/oci-spec-rs#288 (comment) |
Collaborator
|
On the condition they refuse to yank 0.8.2 and re-do with a semver bump, then in this project we must also bump our requirement on oci-spec to be >= 0.8.2 |
cgwalters
approved these changes
Aug 30, 2025
| description = "A Rust library for reading and writing OCI (opencontainers) layout directories" | ||
| version = "0.5.0" | ||
| edition = "2021" | ||
| edition = "2024" |
Collaborator
There was a problem hiding this comment.
OK as is but I would have preferred something like this as a distinct PR.
| .build() | ||
| .unwrap(); | ||
| config.history_mut().push(h); | ||
| match config.history_mut() { |
Collaborator
There was a problem hiding this comment.
OK as is but I think it'd be cleaner to do e.g.
config.history.get_or_insert_with(Vec::new).push(h) or so
Collaborator
|
Followup in #45 |
Contributor
Author
|
@cgwalters thanks for handling this and the follow on PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oci-spec 0.8.2 has made a breaking change to it's
configAPI changing thehistoryfield to be Optional to align with the OCI spec, see youki-dev/oci-spec-rs#288.I've made changes here to accommodate this change and tagged as 0.6.0 as this is breaking change to the API of ocidir.
Whilst in the area I've run cargo fmt and fixed up some clippy warnings about elided lifetimes.
Q for reviewer, should this be released at 0.5.1 so downstream consumers can take the fix without needing to make changes?