Skip to content

Commit

Permalink
perf_counter, x86: remove ack_status() from struct x86_pmu
Browse files Browse the repository at this point in the history
This function is Intel only and not necessary for AMD cpus.

[ Impact: simplify code ]

Signed-off-by: Robert Richter <robert.richter@amd.com>
Cc: Paul Mackerras <paulus@samba.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1241002046-8832-11-git-send-email-robert.richter@amd.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Robert Richter authored and Ingo Molnar committed Apr 29, 2009
1 parent b7f8859 commit dee5d90
Showing 1 changed file with 2 additions and 17 deletions.
19 changes: 2 additions & 17 deletions arch/x86/kernel/cpu/perf_counter.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ struct x86_pmu {
int (*handle_irq)(struct pt_regs *, int);
u64 (*save_disable_all)(void);
void (*restore_all)(u64);
void (*ack_status)(u64);
void (*enable)(int, u64);
void (*disable)(int, u64);
unsigned eventsel;
Expand Down Expand Up @@ -415,23 +414,11 @@ static inline u64 intel_pmu_get_status(u64 mask)
return status;
}

static void intel_pmu_ack_status(u64 ack)
static inline void intel_pmu_ack_status(u64 ack)
{
wrmsrl(MSR_CORE_PERF_GLOBAL_OVF_CTRL, ack);
}

static void amd_pmu_ack_status(u64 ack)
{
}

static void hw_perf_ack_status(u64 ack)
{
if (unlikely(!perf_counters_initialized))
return;

x86_pmu->ack_status(ack);
}

static void intel_pmu_enable_counter(int idx, u64 config)
{
wrmsrl(MSR_ARCH_PERFMON_EVENTSEL0 + idx,
Expand Down Expand Up @@ -788,7 +775,7 @@ static int intel_pmu_handle_irq(struct pt_regs *regs, int nmi)
__x86_pmu_disable(counter, &counter->hw, bit);
}

hw_perf_ack_status(ack);
intel_pmu_ack_status(ack);

/*
* Repeat if there is more work to be done:
Expand Down Expand Up @@ -904,7 +891,6 @@ static struct x86_pmu intel_pmu = {
.handle_irq = intel_pmu_handle_irq,
.save_disable_all = intel_pmu_save_disable_all,
.restore_all = intel_pmu_restore_all,
.ack_status = intel_pmu_ack_status,
.enable = intel_pmu_enable_counter,
.disable = intel_pmu_disable_counter,
.eventsel = MSR_ARCH_PERFMON_EVENTSEL0,
Expand All @@ -918,7 +904,6 @@ static struct x86_pmu amd_pmu = {
.handle_irq = amd_pmu_handle_irq,
.save_disable_all = amd_pmu_save_disable_all,
.restore_all = amd_pmu_restore_all,
.ack_status = amd_pmu_ack_status,
.enable = amd_pmu_enable_counter,
.disable = amd_pmu_disable_counter,
.eventsel = MSR_K7_EVNTSEL0,
Expand Down

0 comments on commit dee5d90

Please sign in to comment.