Refactor error handling #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squashd
approved these changes
Mar 14, 2025
src/api/middleware.ts
Outdated
Comment on lines
25
to
26
| } catch (e) { | ||
| respondWithError(res, 500, "Couldn't authenticate user", e); |
There was a problem hiding this comment.
I'm not consistent with this myself, but I think catch (err) is better than catch (e). Just a personal preference (which I often ignore myself)
waseem-medhat
force-pushed
the
wm_refactor_error_handling
branch
from
d13b336 to
395807f
Compare
Ephim135
pushed a commit
to Ephim135/learn-cicd-typescript-starter
that referenced
this pull request
Jun 22, 2025
…ndling Refactor error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.