Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update japanese.g2p #177

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update japanese.g2p #177

merged 1 commit into from
Sep 26, 2024

Conversation

codebyzeb
Copy link
Contributor

The letter "s" was not included in this segments file, leading to many valid Japanese words being rejected:

> echo 'sushi' | phonemize -b segments -l japanese
fatal error: invalid grapheme

@codebyzeb
Update japanese.g2p
b1a7ab6 
The letter "s" was not included in this segments file, leading to many valid Japanese words being rejected.
@mmmaat mmmaat merged commit f7ce79b into bootphon:master Sep 26, 2024
7 checks passed
@mmmaat
Copy link
Collaborator

mmmaat commented Sep 26, 2024

thanks!

@codebyzeb codebyzeb deleted the patch-1 branch September 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebyzeb @mmmaat