invalid-feedback should be inside input-group
#417
Comments
|
A big thank you for taking the time to report this. And thanks for offering to take a look at a fix. I encourage you to have a go at submitting a PR. We really like to get first-time contributions. Post comments here if you need help and I'll try to give a hand. I'm pretty new to the code myself. Take a look at the CONTRIBUTING document if you haven't already. As you know if you've read #361, we're in the middle of trying to prepare an official release of |
|
Go for it. I have got as far as writing a test for it, but my prospective fix seems... very wrong. (Regex replace after the html is generated) |
|
I'd love to get your test case, if you can push it to your fork and send me a link. Or even just cut and paste it into a comment here. |
|
Will do tomorrow. Away from computer at the moment. |
|
@lcreid Looks good. You appear to have written the exact same test already! :) |
* Test case for #417. * Undoing mess created on wrong branch. * Remove test that accidentally leaked in from another branch. * Working but needs cleanup #417. * Partially cleaned up. Added method for error and help and optionally prepend and append. * Remove unneeded method and parameters. * Test selects error. * Test selects error. * time_zone_select works for new error placement. * Add tests for date, time, datetime selects. * Add tests for date, time, datetime selects. * date, time, datetime tests pass with old implementation. * Date, time, and datetime for new implementation. * Tests for file and collection selects. * File and collection selects with new implementation. * Keep tests but revert lib to try another approach. * form_group tests passing. * Clean up and add back commented test. * checkbox and radio button tests still have old behaviour. * Clean up and block append and prepend.
* Test case for bootstrap-ruby#417. * Undoing mess created on wrong branch. * Remove test that accidentally leaked in from another branch. * Working but needs cleanup bootstrap-ruby#417. * Partially cleaned up. Added method for error and help and optionally prepend and append. * Remove unneeded method and parameters. * Test selects error. * Test selects error. * time_zone_select works for new error placement. * Add tests for date, time, datetime selects. * Add tests for date, time, datetime selects. * date, time, datetime tests pass with old implementation. * Date, time, and datetime for new implementation. * Tests for file and collection selects. * File and collection selects with new implementation. * Keep tests but revert lib to try another approach. * form_group tests passing. * Clean up and add back commented test. * checkbox and radio button tests still have old behaviour. * Clean up and block append and prepend.
The style that triggers display of the error is (amongst others)
.form-control.is-invalid ~ .invalid-feedback.Currently the
.invalid-feedbackdiv is outside the.input-groupand as.is-validis set on the input itself, it's never displayed.This has been addressed in twbs/bootstrap#25020
This means the
.invalid-feedbackshould be located as the last item inside.input-group.I will take a look at this myself and see if I can fix, but it's probably an easy fix for someone who knows the code better. Thanks if you get there first!
The text was updated successfully, but these errors were encountered: