Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests May Not Be Good Enough #674

Closed
lcreid opened this issue Apr 6, 2023 · 0 comments · Fixed by #676
Closed

Tests May Not Be Good Enough #674

lcreid opened this issue Apr 6, 2023 · 0 comments · Fixed by #676
Assignees

Comments

@lcreid
Copy link
Contributor

lcreid commented Apr 6, 2023

The current way we're testing may be too loose in checking the HTML. It looks like XML test we're using isn't strict enough about the order of elements. I discovered that I can make the check box tests pass, even thought the label is being put in front of the check box, instead of after it.

The first step is to reproduce the problem and confirm that it's a real problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant