674 html tests #676
Merged
674 html tests #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on a new implementation, it began to look like tests were passing when they shouldn't have passed. I made a branch off
mainand confirmed that we weren't testing the order of elements, which is significant in HTML.Once that was fixed, it turned out that our code for handling some of the variations was also passing tests that it shouldn't have been passing. A couple of more changes fixed that.
Finally, three tests were failing because the expected strings were incorrect, but the other issues mentioned above were hiding that the tests should have failed.
In the process of fixing, we changed to use Nokogiri's HTML instead of XML. And to make it clear, the assertion helper was changed in all the test files.
Fixes: #674