Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider human attribute name for labels #565

Merged
merged 3 commits into from
Apr 29, 2022
Merged

consider human attribute name for labels #565

merged 3 commits into from
Apr 29, 2022

Conversation

koenpunt
Copy link
Contributor

I'm not sure if it's like this intentionally, but the human_attribute_name was only used when there are errors.

@bootstrap-ruby-bot
Copy link

bootstrap-ruby-bot commented Jun 12, 2020

2 Warnings
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in bootstrap_form's behavior.
⚠️ Please update CHANGELOG.md with a description of your changes. If this PR is not a user-facing change (e.g. just refactoring), you can disregard this.

Here's an example of a CHANGELOG.md entry (place it immediately under the * Your contribution here! line):

* [#565](https://github.com/bootstrap-ruby/bootstrap_form/pull/565): consider human attribute name for labels - [@koenpunt](https://github.com/koenpunt).

Generated by 🚫 Danger

Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I'm afraid I have no idea whether the current behaviour was intentional. I'm guessing that the idea was that if nothing was specified in text, that we would rely on the behaviour of the underlying Rails label method.

Could you please add one or more test cases that show how this PR changes current behaviour?

@donv
Copy link
Collaborator

donv commented Dec 28, 2021

@koenpunt Do you have any examples where this change makes a difference? If not, I will close this PR.

@koenpunt
Copy link
Contributor Author

It's been some time, but what I remember is that labels showed as the name of the label, so some for example "first_name" instead of the more human friendly "First name".

@donv
Copy link
Collaborator

donv commented Jan 9, 2022

@koenpunt Could you add a test case for this that shows the problem?

@UweKubosch
Copy link
Contributor

@koenpunt Thanks for the PR! Could you add a test case that demonstrates the problem and rebase against main?

@donv donv merged commit a40ef76 into bootstrap-ruby:main Apr 29, 2022
@koenpunt koenpunt deleted the patch-1 branch April 29, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants