-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for append and prepend on collection_select (fixes #428) #641
Add support for append and prepend on collection_select (fixes #428) #641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. It's very much appreciated. I haven't yet had time to dig into it -- the PR looks good but it raises some questions in my mind about other methods that don't support prepend and append. If I recall correctly, Bootstrap 4 had specific classes that didn't apply to all types of form elements, but I could be wrong about that.
Do you think there are other methods that don't support prepend and append, but could and should?
I don't consider myself a poweruser of bootstrap or bootstrap_form, so I'm not sure. But the only thing I found now was grouped_collection_select, which you mention in the linked issue. |
Great. Thanks for looking into this. I'll merge this shortly. Thanks for your patience. I don't actually use this gem at the moment, so it always takes me a while to get back up to speed. Thank you for you support and efforts to improve the gem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. It looks good. We really appreciate your contribution.
Thanks for merging this @lcreid! I saw you also did some other changes lately. Do you plan to release more changes together? |
I was trying to get another change in, but obviously I haven't managed that yet. I'll try to do a release soon, but in the meantime you can temporarily change your
Thanks for your patience, and your PR. We really appreciate your contribution. |
Okay, thanks for letting me know 🙂 |
That's a good point. I managed to release version 5.1, including your PR, yesterday. Thanks again for your contribution! |
Thank you 🙂 |
Hello,
thanks a lot for creating this gem!
Today I would have needed a
collection_select
withprepend
and noticed that this does not work yet.Here's a fix for it. I hope everything's alright and would be happy if it got merged 🙂
Best,
Judith