Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gemspec #667

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Update gemspec #667

merged 1 commit into from
Dec 6, 2022

Conversation

siegy22
Copy link
Contributor

@siegy22 siegy22 commented Dec 6, 2022

The current gem packages a whole rails application (demo/) in the .gem file, I assume this was added by mistake 🤔

@siegy22
Update gemspec
11cb812 
The current gem packages a whole rails application (`demo/`) in the `.gem` file, I assume this was added by mistake 🤔
lcreid
lcreid approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Perhaps at one time there was a thought that you should be able to develop for the gem just by downloading the gem, but that's certainly not the way we do things anymore. I think this PR is the right thing to do. Thanks again!

@lcreid lcreid merged commit a15c44c into bootstrap-ruby:main Dec 6, 2022
@donv donv mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcreid lcreid lcreid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siegy22 @lcreid