Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): close on click-out for IE11 (closes #3115) #3117

Merged

Conversation

jacobmllr95
Copy link
Member

Describe the PR

This PR fixes the close on click-out functionality on IE 11.

Background:
IE does not regard document as a node, so document.contains()is always retuning false.
Using document.body.contains()resolves this problem.

Closes #3115.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 requested a review from tmorehouse April 16, 2019 11:05
@jacobmllr95 jacobmllr95 changed the title fix(modal): fix close on click-out for IE11 (closes #3115) fix(modal): close on click-out for IE11 (closes #3115) Apr 16, 2019
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #3117 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3117   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         211      211           
  Lines        3846     3846           
  Branches     1149     1149           
=======================================
  Hits         3811     3811           
  Misses         28       28           
  Partials        7        7
Impacted Files Coverage Δ
src/components/modal/modal.js 99.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7d696...7dbda02. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #3117 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3117   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         211      211           
  Lines        3846     3846           
  Branches     1149     1149           
=======================================
  Hits         3811     3811           
  Misses         28       28           
  Partials        7        7
Impacted Files Coverage Δ
src/components/modal/modal.js 99.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7d696...7dbda02. Read the comment docs.

@jacobmllr95 jacobmllr95 merged commit 9b09e52 into bootstrap-vue:dev Apr 16, 2019
@jacobmllr95 jacobmllr95 deleted the fix-modal-close-on-click-out branch April 16, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<b-modal>: clicking backdrop doesn't close in IE11
2 participants