Skip to content

fix(modal): close on click-out for IE11 (closes #3115) #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix(modal): close on click-out for IE11 (closes #3115) #3117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/modal/modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ export default Vue.extend({
this.$emit(type, bvModalEvt)
},
// UI event handlers
onDialogMousedown(evt) {
onDialogMousedown() {
// Watch to see if the matching mouseup event occurs outside the dialog
// And if it does, cancel the clickOut handler
const modal = this.$refs.modal
Expand All @@ -551,8 +551,8 @@ export default Vue.extend({
},
onClickOut(evt) {
// Do nothing if not visible, backdrop click disabled, or element
// that generated click event is no longer in document
if (!this.is_visible || this.noCloseOnBackdrop || !contains(document, evt.target)) {
// that generated click event is no longer in document body
if (!this.is_visible || this.noCloseOnBackdrop || !contains(document.body, evt.target)) {
return
}
if (this.ignoreBackdropClick) {
Expand Down