feat(pagination+pagination-nav): remove need for custom active focus style #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the need for custom CSS until properly addressed in Bootstrap V4. See twbs/bootstrap#24838
tmorehouse
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1384 +/- ##
==========================================
- Coverage 43.12% 42.95% -0.18%
==========================================
Files 130 130
Lines 2887 2873 -14
Branches 892 889 -3
==========================================
- Hits 1245 1234 -11
+ Misses 1254 1249 -5
- Partials 388 390 +2
Continue to review full report at Codecov.
|
pi0
pushed a commit
that referenced
this pull request
Nov 29, 2017
…style (#1384) * [pagination-mixin] use btn-primary to get focus styling Avoids the need for custom CSS until properly addressed in Bootstrap V4. See twbs/bootstrap#24838 * Update pagination-nav.js * Delete pagination-nav.vue * Update pagination.js * Delete pagination.vue * ESLint * ESLint * Include active style when pagination disabled * Update pagination.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the need for custom CSS until properly addressed in Bootstrap V4.
Interim fix based on 2nd option at twbs/bootstrap#24838 (using the class
btn-primaryon the active page-link)Since no custom style is required anymore, the SFC
.vuefiles were replaced with.jsfiles