Skip to content

fix(form-input, form-textarea): handle case where input has been removed from document (closes #3498) #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jun 12, 2019

Describe the PR

In rare instances, the input may have been removed from document (during destroy phase) and browser autocomplete triggers a change before removed from document, resulting in this.$refs.input being undefined. Adds in a check in mixins/form-text to handle this edge case.

Closes #3498

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #3501 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3501   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files         224      224           
  Lines        4303     4303           
  Branches     1229     1229           
=======================================
  Hits         4271     4271           
  Misses         26       26           
  Partials        6        6
Impacted Files Coverage Δ
src/mixins/form-text.js 95.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8533868...1f5b522. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(form-input): handle case where input has been removed from document (closes #3498) fix(form-input, form-textarea): handle case where input has been removed from document (closes #3498) Jun 12, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tmorehouse tmorehouse merged commit 9a62e44 into dev Jun 12, 2019
@tmorehouse tmorehouse deleted the issue/3498 branch June 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input autocomplete got undefined error when upgrated from rc.19
2 participants