Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): adjustments to sort icon positioning SCSS (closes #3563) #3568

Merged
merged 7 commits into from
Jun 25, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jun 25, 2019

Describe the PR

Switch from absolute positioning to display: inline-block + float: right + ::before (instead of ::after) for sort icons.

Removes need for position: relative; on table header/footer cells which can interfere with dropdowns and tooltips/popovers in headers of responsive tables (note boundary option needs to be set on dropdown, tooltip, popover, to allow to break out of responsive table container)

closes #3563

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) SCSS update

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Switch from absolute positioning to inline-block for sort icons.

Removes need for `position: relative;` on table header/footer cells which can interfere with dropdowns in headers of responsive tables
@tmorehouse tmorehouse changed the title fix(table): adjustments to sort icon positioning fix(table): adjustments to sort icon positioning (closes #3563) Jun 25, 2019
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #3568 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3568   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files         224      224           
  Lines        4315     4315           
  Branches     1231     1231           
=======================================
  Hits         4283     4283           
  Misses         26       26           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48d3dc...338636f. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(table): adjustments to sort icon positioning (closes #3563) fix(table): adjustments to sort icon positioning SCSS (closes #3563) Jun 25, 2019
@tmorehouse tmorehouse marked this pull request as ready for review June 25, 2019 14:26
@tmorehouse tmorehouse requested a review from jacobmllr95 June 25, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown boundary="window" fails within responsive table header
2 participants