Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount-point can be determined incorrectly when mounting more then one devices simultaneously #332

Closed
boozook opened this issue Apr 28, 2024 · 0 comments
Closed

Mount-point can be determined incorrectly when mounting more then one devices simultaneously #332

boozook opened this issue Apr 28, 2024 · 0 comments
Assignees
@boozook
Labels
bug Something isn't working cargo About cargo or cargo-playdate

Comments

@boozook
Copy link
Owner

boozook commented Apr 28, 2024

Steps to reproduce:

  1. Connect more then one devices in data mode
  2. cargo run -p=playdate-tool -- mount --wait
  3. Check printed mount-points of each mounted device
    Some mount-points can be determined incorrectly by another device that mounted earlier.

This is because playdate-device uses the method (as fallback) of guessing the path by device name and then checking. But this method can work only if all connected devices have unique names or only one device.
@boozook boozook added bug Something isn't working cargo About cargo or cargo-playdate labels Apr 28, 2024
@boozook boozook self-assigned this Apr 28, 2024
boozook added a commit that referenced this issue Apr 28, 2024
@boozook
Fix wrong mount-point determined by another device 🤦🏻‍♂️ (#332)
f4a681e
@boozook boozook moved this to Ready in Playdate Development Apr 28, 2024
@boozook boozook mentioned this issue Apr 28, 2024
Merged
boozook added a commit that referenced this issue Apr 29, 2024
@boozook
Fix deserialisation error when multiple devices and some of them does…
f8e5847 
…n't contain serial-number (#331, #332)

* Fix deserialisation error when multiple devices and some of them doesn't contain serial-number (#331)

* Fix wrong mount-point determined by another device 🤦🏻‍♂️ (#332)
boozook added a commit that referenced this issue Apr 30, 2024
@boozook
Fixes for run-on-device bugs (#328, #329, #331, #332)
8d6675a 
* Mount/unmount awaiting time now configurable witn env: `PD_MOUNT_TIMEOUT` & `PD_UNMOUNT_TIMEOUT`, values in ms.

* Update deps and bump `pdtool` and `cargo-playdate`

* Tests for serial-number format parser (#329)

* Fix accepting empty path by `diskutil` (#330)

* Fix deserialisation error when multiple devices and some of them doesn't contain serial-number (#331)

* Fix wrong mount-point determined by another device 🤦🏻‍♂️ (#332)
@boozook boozook closed this as completed Apr 30, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in Playdate Development Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boozook boozook

Labels
bug Something isn't working cargo About cargo or cargo-playdate
Projects
Playdate Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boozook